Wait for pending AJAX in acceptance tests. #264
Conversation
Ember internally tracks AJAX requests in the same way that we do here for legacy style "acceptance" tests using the `ember-testing.js` asset provided by emberjs/ember.js itself. When `@ember/test-helpers`'s `settled` utility is used in a legacy acceptance test context any pending AJAX requests are not properly considered during the `isSettled` check below. This utilizes a local utility method present in Ember since around 2.8.0 to properly consider pending AJAX requests done within legacy acceptance tests.
|
@rwjblue do you think it's possible to write tests for this? |
|
yes, I think so, but I am not 100% certain. I am working on the failing test (the failure is legit) then I'll take a stab at adding a reasonable facsimile of a regression test... |
|
Just pushed up the fix for the prior failure (leaky state in the legacy acceptance testing system itself), and a regression test. The test was somewhat gnarly to add but I confirmed that the test failed prior to the changes in |
rwjblue
force-pushed
the
handle-acceptance-test-ajax
branch
2 times, most recently
from
245c02e to
c4894e4
Compare
|
FYI - I added a guard to prevent the new regression test from running on Ember versions older than 2.8. It is possible that I could have made it work, but I'm not sure and this issue has sucked enough time already. 😡 We can always try to address if someone provides a compelling case (and hopefully PR 😝 ), but since Ember 2.4 is already sunsetted I think its ok if some features don't work properly... |
rwjblue
force-pushed
the
handle-acceptance-test-ajax
branch
from
c4894e4 to
1acecfc
Compare
|
awesome work @rwjblue ❤️ |
Ember internally tracks AJAX requests in the same way that we do here for legacy style "acceptance" tests using the
ember-testing.jsasset provided by emberjs/ember.js itself. When@ember/test-helpers'ssettledutility is used in a legacy acceptance test context any pending AJAX requests are not properly considered during theisSettledcheck below.This utilizes a local utility method present in Ember since around 2.8.0 to properly consider pending AJAX requests done within legacy acceptance tests.